Re: [dpdk-dev] [PATCH v5 1/3] examples/eventdev_pipeline: added sample app

[Hunt, David]

On 6/7/2017 11:04 AM, Hunt, David wrote:


On 6/7/2017 4:31 AM, Jerin Jacob wrote:

Note:
Change application to new name.

checkpatch.sh
-----------------

WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to
using 'consumer', this function's name, in a string
#294: FILE: examples/eventdev_pipeline_sw_pmd/main.c:178:
+        printf("# consumer RX=%"PRIu64", time %"PRIu64 "ms, "

WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to
using 'worker', this function's name, in a string
#453: FILE: examples/eventdev_pipeline_sw_pmd/main.c:337:
+        printf("  worker %u thread done. RX=%zu TX=%zu\n",

total: 0 errors, 2 warnings, 1078 lines checked

These are false positives. The text in the messages are not meant to 
be the function name.
If anything, I would prefer to change the function names to have " 
_thread"?



Or perhaps, better still, change the function names to verbs, i.e. 
produce() consume(), do_work().

Regards,
Dave.