> -----Original Message----- > From: Trahe, Fiona > Sent: Wednesday, July 19, 2017 3:06 PM > To: De Lara Guarch, Pablo <[email protected]>; Jain, Deepak K > <[email protected]>; Griffin, John <[email protected]> > Cc: [email protected]; Trahe, Fiona <[email protected]> > Subject: RE: [PATCH] crypto/qat: fix session initialization > > > > > -----Original Message----- > > From: De Lara Guarch, Pablo > > Sent: Wednesday, July 19, 2017 5:59 AM > > To: Trahe, Fiona <[email protected]>; Jain, Deepak K > > <[email protected]>; Griffin, John <[email protected]> > > Cc: [email protected]; De Lara Guarch, Pablo > > <[email protected]> > > Subject: [PATCH] crypto/qat: fix session initialization > > > > When creating a session, if there is a failure when setting some of > > the parameters, QAT was not propagating the error to the session > > initialization function. > > Therefore, it was reporting a success, when it should be report a > > failure. > > > > Fixes: b3bbd9e5f265 ("cryptodev: support device independent sessions") > > > > Signed-off-by: Pablo de Lara <[email protected]> > In the 3 fn prototypes in qat_crypto.h it would be nice to remove the > _private from struct qat_session *session_private. Apart from that it's fine. > > Acked-by: Fiona Trahe <[email protected]>
I fixed that when merging the patch :) Thanks! Applied to dpdk-next-crypto. Pablo
