Hi, > -----Original Message----- > From: Yigit, Ferruh > Sent: Monday, August 21, 2017 7:04 PM > To: Hu, Jiayu <[email protected]>; [email protected] > Cc: Ananyev, Konstantin <[email protected]>; Tan, Jianfeng > <[email protected]>; [email protected]; Wu, Jingjing > <[email protected]>; Yao, Lei A <[email protected]> > Subject: Re: [PATCH v2 2/2] doc: update testpmd user guide for the > heavyweight mode GRO > > On 8/17/2017 10:08 AM, Jiayu Hu wrote: > > This patch is to update testpmd user guide for the heavyweight mode GRO. > > Documentation can be part of the implementation patch. > It is good to split patches logically, but I don't see the benefit of > splitting patch as documentation and implementation.
OK, I will combine these two patches in the next version. > > > > > Signed-off-by: Jiayu Hu <[email protected]> > > --- > > <...> > > > > > +set gro flush interval > > +~~~~~~~~~~~~~~~~~~~~~~ > > + > > +Set the interval of flushing GROed packets from reassembly tables:: > > + > > + testpmd> set gro flush interval (num) > > + > > +In the heavyweight mode, GROed packets are stored in reassembly tables > > +and need flushing from the tables manually. This command is to set the > > +number of performing GRO operations between two flushing operations. > > + > > +The value of ``num`` should be in the range of 0 to > ``GRO_MAX_FLUSH_INTERVAL``. > > +``0`` means flush GROed packets from the tables when one GRO operation > > +finishes. > > It can be good to mention default interval value is > GRO_DEFAULT_FLUSH_INTERVAL if this command not issued. Thanks, I will add it in the next patch. BRs, Jiayu > > > + > > mac_addr add > > ~~~~~~~~~~~~ > > > >
