Hi , Dave: Thanks for your reminder. It looks like that I don't cover the folder /test/, if needed, I will cover them next version.
Thanks Zhiyong > -----Original Message----- > From: Hunt, David > Sent: Monday, September 4, 2017 10:16 PM > To: Yang, Zhiyong <[email protected]>; [email protected] > Cc: [email protected]; Yigit, Ferruh <[email protected]>; Wiles, Keith > <[email protected]>; [email protected] > Subject: Re: [dpdk-dev] [PATCH v2 2/4] examples: increase port_id range > > Hi Zhiyong, > > > > On 4/9/2017 6:57 AM, Zhiyong Yang wrote: > > Modify port_id related code in examples accordingly since port_id > > definition in lib and pmd changes. > > > > Fix some original checkpatch issues and remove some unnecessary cast > > at the same time. > > > > Signed-off-by: Zhiyong Yang <[email protected]> > > --- > ---big snip--- > > > I noticed that in /test/test/test_pmd_perf.c after applying the patch set, > RTE_PORT_ALL is still 8-bit: > > -#define RTE_PORT_ALL (~(uint8_t)0x0) > > This probably needs to be: > > +#define RTE_PORT_ALL (~(portid_t)0x0) > > Regards, > Dave. > > >
