> From: Pavan Nikhilesh [mailto:[email protected]]
> Sent: Wednesday, August 23, 2017 4:19 PM
> To: [email protected]
> Cc: Van Haaren, Harry <[email protected]>; Pavan Nikhilesh
> <[email protected]>
> Subject: [dpdk-dev] [PATCH] timer: fix reset on service cores
>
> - API rte_timer_reset() should be able to register timers on service
> lcores as they are EAL threads.
Nitpick comment: remove - at the start. (I'd ignore this, but v2 required based
on below anyway..)
> Fixes: af75078fece3 ("first public release")
I'm not sure this is a fix to the first release.. service cores has only been
added recently, I feel bad "git blaming" the first release :)
I suggest renaming the title to "timer: allow timer reset on service cores",
and removing the Fixes: tag.
>
> Signed-off-by: Pavan Nikhilesh <[email protected]>
With above changes,
Acked-by: Harry van Haaren <[email protected]>
> ---
> This patch depends on http://dpdk.org/dev/patchwork/patch/27818/
> lib/librte_timer/rte_timer.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c
> index 5ee0840..a5a045c 100644
> --- a/lib/librte_timer/rte_timer.c
> +++ b/lib/librte_timer/rte_timer.c
> @@ -432,7 +432,8 @@ rte_timer_reset(struct rte_timer *tim, uint64_t ticks,
> uint64_t period;
>
> if (unlikely((tim_lcore != (unsigned)LCORE_ID_ANY) &&
> - !rte_lcore_is_enabled(tim_lcore)))
> + !(rte_lcore_is_enabled(tim_lcore) ||
> + rte_lcore_is_service_lcore(tim_lcore))))
> return -1;
>
> if (type == PERIODICAL)
> --
> 2.7.4
