Hi Pablo > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Monday, September 18, 2017 7:48 PM > To: Tan, Jianfeng; Gaƫtan Rivet > Cc: dev@dpdk.org; Richardson, Bruce; Ananyev, Konstantin; > tho...@monjalon.net; y...@fridaylinux.org; maxime.coque...@redhat.com; > mtetsu...@gmail.com; Yigit, Ferruh > Subject: RE: [dpdk-dev] [PATCH 04/12] vdev: move to drivers/bus > > ... > > > Let's say the cryptodev lib must be updated. > > > I understand the need to move rte_cryptodev_vdev.h outside > > > librte_cryptodev, but I guess this exposes the vdev bus to ABI / API > > > instability due to a third-party subsystem? > > > > Thank you for bringing up this question. I really don't want to move > > these crypto-specific files into bus/vdev/. It's just some helper > > functions to be called by crypto vdev drivers. And what's more, the only > > dependence on vdev is that the API rte_cryptodev_vdev_pmd_init() has a > > parameter of struct rte_vdev_device, which is totally not necessary, as > > it only needs a struct rte_device parameter. > > > > In all, I'd prefer to change this specific API and move those > > crypto-specific files back to lib/librte_crypto (just like ether dev and > > eventdev); but it needs API change announcement. > > > > Any thoughts? > > I think we should keep this API in cryptodev. It looks strange to have some > Crypto specific functions in a file like this that should contain generic vdev > functions.
OK, I'll try to put those files back, see if possible to add a dependency on librte_bus_vdev in lib_cryptodev. ... > > Btw, for future times, strip out all the text where there are no comments, > so it is easier to review by others. Thank you for the reminder. Thanks, Jianfeng > > Thanks, > Pablo