> -----Original Message----- > From: Iremonger, Bernard > Sent: Thursday, September 7, 2017 5:43 PM > To: [email protected]; Yigit, Ferruh <[email protected]>; Ananyev, > Konstantin <[email protected]>; Dumitrescu, Cristian > <[email protected]>; [email protected] > Cc: Iremonger, Bernard <[email protected]>; [email protected] > Subject: [PATCH v5 2/6] librte_table: fix acl lookup function > > The rte_table_acl_lookup() function was returning data from acl_memory > instead of acl_rule_memory. > > Fixes: 166923eb2f78 ("table: ACL") > Cc: [email protected] > > Signed-off-by: Bernard Iremonger <[email protected]> > --- > lib/librte_table/rte_table_acl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_table/rte_table_acl.c > b/lib/librte_table/rte_table_acl.c > index e84b437..258916d 100644 > --- a/lib/librte_table/rte_table_acl.c > +++ b/lib/librte_table/rte_table_acl.c > @@ -794,7 +794,7 @@ struct rte_table_acl { > if (action_table_pos != 0) { > pkts_out_mask |= pkt_mask; > entries[pkt_pos] = (void *) > - &acl->memory[action_table_pos * > + &acl->acl_rule_memory[action_table_pos * > acl->entry_size]; > rte_prefetch0(entries[pkt_pos]); > } > -- > 1.9.1
NACK Existing code is correct, proposed code changes are wrong (for same reasons described in patch 1 of this patch set).
