> -----Original Message-----
> From: Rybalchenko, Kirill
> Sent: Wednesday, September 20, 2017 1:54 AM
> To: [email protected]
> Cc: Rybalchenko, Kirill <[email protected]>; Chilikin, Andrey
> <[email protected]>; Xing, Beilei <[email protected]>; Wu,
> Jingjing <[email protected]>
> Subject: [PATCH v5 1/2] net/i40e: get information about protocols defined in
> ddp profile
>
> This patch adds new package info types to get list of protocols, pctypes and
> ptypes defined in a profile
>
> ---
> v3
> info_size parameter always represents size of the info buffer in bytes
>
> Signed-off-by: Kirill Rybalchenko <[email protected]>
> ---
> drivers/net/i40e/rte_pmd_i40e.c | 171
> ++++++++++++++++++++++++++++++++++++++++
> drivers/net/i40e/rte_pmd_i40e.h | 25 ++++++
> 2 files changed, 196 insertions(+)
>
> diff --git a/drivers/net/i40e/rte_pmd_i40e.c
> b/drivers/net/i40e/rte_pmd_i40e.c index c08e07a..80af18b 100644
> --- a/drivers/net/i40e/rte_pmd_i40e.c
> +++ b/drivers/net/i40e/rte_pmd_i40e.c
> @@ -1706,6 +1706,26 @@ rte_pmd_i40e_process_ddp_package(uint8_t
> port, uint8_t *buff,
> return status;
> }
>
> +/* Get number of tvl records in the section */ static unsigned int
> +i40e_get_tlv_section_size(struct i40e_profile_section_header *sec) {
> + unsigned int i, nb_rec, nb_tlv = 0;
> + struct i40e_profile_tlv_section_record *tlv;
> +
> + if (!sec)
> + return nb_tlv;
> +
> + /* get number of records in the section */
> + nb_rec = sec->section.size / sizeof(struct
> i40e_profile_tlv_section_record);
> + for (i = 0; i < nb_rec; ) {
> + tlv = (struct i40e_profile_tlv_section_record *)&sec[1 + i];
> + i += tlv->len;
> + nb_tlv++;
> + }
> + return nb_tlv;
In my opinion, nb_rec should be the same with nb_tlv, why need the for loop to
get and return nb_tlv? Please correct me if I'm wrong.
<snip>
> +
> + /* get list of protocols */
> + if (type == RTE_PMD_I40E_PKG_INFO_PROTOCOL_LIST) {
> + uint32_t i, j, nb_rec;
> + struct rte_pmd_i40e_proto_info *pinfo;
> + struct i40e_profile_section_header *proto;
> + struct i40e_profile_tlv_section_record *tlv;
> +
> + proto = i40e_find_section_in_profile(SECTION_TYPE_PROTO,
> + (struct
> i40e_profile_segment *)
> + i40e_seg_hdr);
> + nb_rec = i40e_get_tlv_section_size(proto);
> + if (info_size < nb_rec * sizeof(struct
> rte_pmd_i40e_proto_info)) {
> + PMD_DRV_LOG(ERR, "Invalid information buffer
> size");
> + return -EINVAL;
> + }
> + pinfo = (struct rte_pmd_i40e_proto_info *)info_buff;
> + for (i = 0; i < info_size; i++) {
You changed info_size represents the size of the info buffer, then should use
'i < nb_rec' instead of ' i < info_size ' in for loop, otherwise there will be
unexpected issue.
> + pinfo[i].proto_id = RTE_PMD_I40E_PROTO_UNUSED;
> + memset(pinfo[i].name, 0,
> RTE_PMD_I40E_DDP_NAME_SIZE);
> + }
> + if (nb_rec == 0)
> + return I40E_SUCCESS;
Why not adding the condition just after 'nb_rec =
i40e_get_tlv_section_size(proto);' ?
> + /* get number of records in the section */
> + nb_rec = proto->section.size /
> + sizeof(struct
> i40e_profile_tlv_section_record);
Why do we need to get the nb_rec again? I think the value should be the same as
the last value.
> + tlv = (struct i40e_profile_tlv_section_record *)&proto[1];
> + for (i = j = 0; i < nb_rec; j++) {
> + pinfo[j].proto_id = tlv->data[0];
> + strncpy(pinfo[j].name, (const char *)&tlv->data[1],
> + I40E_DDP_NAME_SIZE);
> + i += tlv->len;
> + tlv = &tlv[tlv->len];
> + }
> + return I40E_SUCCESS;
> + }
> +
<snip>
Same comments for get RTE_PMD_I40E_PKG_INFO_PCTYPE_LIST and
RTE_PMD_I40E_PKG_INFO_PTYPE_LIST.
