On Tuesday 10 October 2017 01:09 PM, Thomas Monjalon wrote:
10/10/2017 09:01, Shreyansh Jain:
Fixes: 5b22cf744689 ("bus/dpaa: introducing FMan configurations")
Fixes: 37f9b54bd3cf ("net/dpaa: support Tx and Rx queue setup")

These lines should appear after the explanation.

Ok. That I missed -  I will fix and send updated patch.


Cc: shreyansh.j...@nxp.com

With the IOVA auto detection changes, bus scan is performed before
memory initialization. DPAA bus scan must not use rte_malloc in
its path.

If the scan has been broken by IOVA detection, you should reference
IOVA in Fixes line, not DPAA.

I was of two minds before sending this patch with above Fixes lines: This change is because of IOVA but at the time IOVA patch was introduced, this bus was not part of master. So, ideally, in the net-next itself the integration should have been with fixed code - but, I ended up verifying base patches without IOVA patches (some earlier snapshot of net-next).

Anyways, I will send another patch with IOVA as fix line.

Reply via email to