On Wed, Oct 11, 2017 at 03:38:36PM +0200, Thomas Monjalon wrote: > Hi, > > 09/10/2017 17:00, Tomasz Duszynski: > > # > > +# Compile Marvell PMD driver > > +# > > +CONFIG_RTE_LIBRTE_MRVL_PMD=n > > +CONFIG_RTE_LIBRTE_MRVL_DEBUG=n > > +CONFIG_RTE_MRVL_MUSDK_DMA_MEMSIZE=41943040 > > We are trying to remove build-time configurations and behave like > a true library. > > The DEBUG config options are now prohibited. > Where is it used in your code? > If it is used for logs, you should switch to the dynamic log config. > > What is MUSDK_DMA_MEMSIZE? > If the value cannot change, it must be a constant in the code. > If it can change, it should be a run-time driver option.
It's up to the user what MUSDK_DMA_MEMSIZE is going to be. Currently it's set to value that should work it all cases. Except that, MUSDK_DMA_MEMSIZE is used as synchronization point for net and crypto (on condition they are used together i.e ipsec-secgw). Suppose we have two different MUSDK_DMA_MEMSIZE defined for net/crypto then dma memsize allocated will depend on driver probing sequence which might confuse user. If you have any better idea please share it with us. Thanks. > > Thank you and welcome -- - Tomasz Duszyński
