My initial thought was that the whole patchset is applied as a whole at once to dpdk. Will get the source files submitted with belonging Makefiles to get it incrementally compilable.
Thanks Anatoly for catching this. > -----Original Message----- > From: Burakov, Anatoly > Sent: Wednesday 4 October 2017 17:14 > To: Mokhtar, Amr <[email protected]>; [email protected] > Cc: Power, Niall <[email protected]>; Macnamara, Chris > <[email protected]> > Subject: Re: [dpdk-dev] [PATCH v1 6/6] bbdev: auxiliary changes to DPDK > framework > > On 30-Sep-17 2:37 AM, Amr Mokhtar wrote: > > diff --git a/mk/rte.app.mk b/mk/rte.app.mk index c25fdd9..7286ad9 > > 100644 > > --- a/mk/rte.app.mk > > +++ b/mk/rte.app.mk > > @@ -93,6 +93,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_NET) += -lrte_net > > _LDLIBS-$(CONFIG_RTE_LIBRTE_ETHER) += -lrte_ethdev > > _LDLIBS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += -lrte_cryptodev > > _LDLIBS-$(CONFIG_RTE_LIBRTE_EVENTDEV) += -lrte_eventdev > > +_LDLIBS-$(CONFIG_RTE_LIBRTE_BBDEV) += -lrte_bbdev > > _LDLIBS-$(CONFIG_RTE_LIBRTE_MEMPOOL) += -lrte_mempool > > _LDLIBS-$(CONFIG_RTE_DRIVER_MEMPOOL_RING) += -lrte_mempool_ring > > _LDLIBS-$(CONFIG_RTE_LIBRTE_RING) += -lrte_ring > > @@ -146,6 +147,18 @@ endif # $(CONFIG_RTE_LIBRTE_VHOST) > > _LDLIBS-$(CONFIG_RTE_LIBRTE_VMXNET3_PMD) += - > lrte_pmd_vmxnet3_uio > > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_XENVIRT) += -lrte_pmd_xenvirt - > lxenstore > > > > +ifeq ($(CONFIG_RTE_LIBRTE_BBDEV),y) > > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_BBDEV_NULL) += - > lrte_pmd_bbdev_null > > + > > +# TURBO SOFTWARE PMD is dependent on the BBLIB library > > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_BBDEV_TURBO_SW) += > > +-lrte_pmd_bbdev_turbo_sw > > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_BBDEV_TURBO_SW) += > > +-L$(BBLIB_PATH)/lib_common -lcommon > > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_BBDEV_TURBO_SW) += > > +-L$(BBLIB_PATH)/lib_crc -lcrc > > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_BBDEV_TURBO_SW) += > > +-L$(BBLIB_PATH)/lib_turbo -lturbo > > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_BBDEV_TURBO_SW) += > > +-L$(BBLIB_PATH)/lib_rate_matching -lrate_matching > > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_BBDEV_TURBO_SW) += -lirc -limf > > +-lstdc++ -lipps endif # CONFIG_RTE_LIBRTE_BBDEV > > + > > ifeq ($(CONFIG_RTE_LIBRTE_CRYPTODEV),y) > > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AESNI_MB) += -lrte_pmd_aesni_mb > > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AESNI_MB) += - > L$(AESNI_MULTI_BUFFER_LIB_PATH) -lIPSec_MB > > > > Changes to makefiles should probably go in with the patches that introduce the > libraries. As it stands, if something breaks the build inside one of the > PMD's or > BBDEV itself (which is the case right now), we won't know about it until this > patch. > > -- > Thanks, > Anatoly
