Re: [dpdk-dev] [PATCH 10/11] app/testpmd: compile even if ixgbe anf bnxt pmds are not compiling

[Aviad Yehezkel]

On 10/16/2017 12:44 PM, Sergio Gonzalez Monroy wrote:

On 14/10/2017 14:28, avia...@dev.mellanox.co.il wrote:

From: Aviad Yehezkel <avia...@mellanox.com>

Signed-off-by: Aviad Yehezkel <avia...@mellanox.com>
Signed-off-by: Nicolai Radu <radu.nico...@intel.com>
---
  app/test-pmd/cmdline.c | 13 ++++++++++---
  app/test-pmd/config.c  | 12 +++++++++++-
  2 files changed, 21 insertions(+), 4 deletions(-)

This patch is modifying a different app, should be on its own.

Thanks,
Sergio

Agreed. Will send as different patch in next version with fixes.

Thanks,
Aviad.

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index bb19d72..e4a636e 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -7377,11 +7377,17 @@ struct cmd_set_vf_rxmode {
  };
    static void
-cmd_set_vf_rxmode_parsed(void *parsed_result,
-               __attribute__((unused)) struct cmdline *cl,
-               __attribute__((unused)) void *data)
+cmd_set_vf_rxmode_parsed(
+#if defined(RTE_LIBRTE_IXGBE_PMD) || defined(RTE_LIBRTE_BNXT_PMD)
+        void *parsed_result,
+#else
+        __attribute__((unused)) void *parsed_result,
+#endif
+        __attribute__((unused)) struct cmdline *cl,
+        __attribute__((unused)) void *data)
  {
      int ret = -ENOTSUP;
+#if defined(RTE_LIBRTE_IXGBE_PMD) || defined(RTE_LIBRTE_BNXT_PMD)
      uint16_t rx_mode = 0;
      struct cmd_set_vf_rxmode *res = parsed_result;
  @@ -7396,6 +7402,7 @@ cmd_set_vf_rxmode_parsed(void *parsed_result,
          else if (!strncmp(res->mode, "MPE",3))
              rx_mode |= ETH_VMDQ_ACCEPT_MULTICAST;
      }
+#endif
    #ifdef RTE_LIBRTE_IXGBE_PMD
      if (ret == -ENOTSUP)
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index bafe76c..d38ba82 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c

@@ -3181,7 +3181,17 @@ set_queue_rate_limit(portid_t port_id, uint16_t queue_idx, uint16_t rate)

  }
    int

-set_vf_rate_limit(portid_t port_id, uint16_t vf, uint16_t rate, uint64_t q_msk)

+set_vf_rate_limit(
+        portid_t port_id,
+#if defined(RTE_LIBRTE_IXGBE_PMD) || defined(RTE_LIBRTE_BNXT_PMD)
+        uint16_t vf,
+        uint16_t rate,
+        uint64_t q_msk)
+#else
+        __attribute__((unused)) uint16_t vf,
+        __attribute__((unused)) uint16_t rate,
+        __attribute__((unused)) uint64_t q_msk)
+#endif
  {
      int diag = -ENOTSUP;