-----Original Message----- > Date: Tue, 17 Oct 2017 03:14:34 +0530 > From: Nipun Gupta <[email protected]> > To: [email protected] > CC: [email protected], [email protected], > [email protected], Nipun Gupta <[email protected]> > Subject: [PATCH v3 3/4] event/dpaa2: support event eth adapter > X-Mailer: git-send-email 1.9.1 > > Signed-off-by: Nipun Gupta <[email protected]> > Reviewed-by: Nikhil Rao <[email protected]> > Acked-by: Hemant Agrawal <[email protected]> > --- > Changes in v3: > Fix shared library build > Changes in v2: > Support rx_queue_id = -1 in eth adapter queue and and del (Nikhil) > Remove duplicate returns (Nikhil) > > drivers/Makefile | 2 +- > drivers/event/Makefile | 4 +- > drivers/event/dpaa2/Makefile | 2 + > drivers/event/dpaa2/dpaa2_eventdev.c | 151 > ++++++++++++++++++++++++++++++++++- > drivers/event/dpaa2/dpaa2_eventdev.h | 8 ++ > 5 files changed, 163 insertions(+), 4 deletions(-) > > diff --git a/drivers/Makefile b/drivers/Makefile > index 0467250..db0cd76 100644 > --- a/drivers/Makefile > +++ b/drivers/Makefile > @@ -39,6 +39,6 @@ DEPDIRS-net := bus mempool > DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += crypto > DEPDIRS-crypto := bus mempool > DIRS-$(CONFIG_RTE_LIBRTE_EVENTDEV) += event > -DEPDIRS-event := bus mempool > +DEPDIRS-event := bus mempool net > > include $(RTE_SDK)/mk/rte.subdir.mk > diff --git a/drivers/event/Makefile b/drivers/event/Makefile > index d09be74..e119d60 100644 > --- a/drivers/event/Makefile > +++ b/drivers/event/Makefile > @@ -31,7 +31,7 @@ > > include $(RTE_SDK)/mk/rte.vars.mk > > -core-libs := librte_eal librte_eventdev > +core-libs := librte_eal librte_ether librte_eventdev
The above two changes makes sense to me as eventdev-ethdev Rx adapter is depended on ethdev and there could be an Rx adapter implementation in event area that may use ethdev driver exported API. Can you split driver/event and driver/Makefile change to different patch? Other than that, This patch set looks good to me and it is ready to merge. But, There is a compilation error[1] in event-next tree be case of Hemant reported problem[2].I can apply this patch set once the solution for the reported problem[3] is applied to master branch(so that I pull those changes to next-eventdev to avoid build issue) [1] Applying: event/dpaa2: support event eth adapter /export/dpdk-next-eventdev/mk/rte.subdir.mk:62: target 'event' given more than once in the same rule make[2]: Circular mempool <- event dependency dropped. [2] http://dpdk.org/ml/archives/dev/2017-October/079249.html [3] http://dpdk.org/ml/archives/dev/2017-October/079324.html
