Hi Pablo, > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Wednesday, October 18, 2017 9:10 PM > To: Yang, Zhiyong <[email protected]>; [email protected] > Cc: Yigit, Ferruh <[email protected]>; Yang, Zhiyong > <[email protected]> > Subject: RE: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix port id type > > Hi Zhiyong, > > > -----Original Message----- > > From: dev [mailto:[email protected]] On Behalf Of Zhiyong Yang > > Sent: Wednesday, October 18, 2017 10:50 AM > > To: [email protected] > > Cc: Yigit, Ferruh <[email protected]>; Yang, Zhiyong > > <[email protected]> > > Subject: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix port id type > > > > Fix port id issue and remove unnecessary cast. > > > > Fixes: f8244c6399d9 ("ethdev: increase port id range") > > Signed-off-by: Zhiyong Yang <[email protected]> > > Actually, I think we can extend this patch to declare all variables related > to port > ids to uint16_t. > I have seen the following: "l2fwd_dst_ports", "portid", "dest_portid", > "dst_port". > > Rest of the patch looks good to me, so you can keep the ack if you are doing a > v2. > > Acked-by: Pablo de Lara <[email protected]> >
Thanks for your review and acked by. I can do as you comment in V2. zhiyong
