Dumb unconditional iteration on flow rules should be performed using the dedicated macro.
Signed-off-by: Adrien Mazarguil <adrien.mazarg...@6wind.com> Acked-by: Nelio Laranjeiro <nelio.laranje...@6wind.com> --- drivers/net/mlx4/mlx4_flow.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c index 5c4bf8e..5af6efb 100644 --- a/drivers/net/mlx4/mlx4_flow.c +++ b/drivers/net/mlx4/mlx4_flow.c @@ -1460,9 +1460,7 @@ mlx4_flow_sync(struct priv *priv, struct rte_flow_error *error) return ret; } /* Toggle the remaining flow rules . */ - for (flow = LIST_FIRST(&priv->flows); - flow; - flow = LIST_NEXT(flow, next)) { + LIST_FOREACH(flow, &priv->flows, next) { ret = mlx4_flow_toggle(priv, flow, priv->started, error); if (ret) return ret; -- 2.1.4