Yes, just finished my testing.
Will send v2 in a moment and Akhil will send v5 rebased above them for
rte_security.
Thanks!
On 10/19/2017 9:16 PM, De Lara Guarch, Pablo wrote:
-----Original Message-----
From: Aviad Yehezkel [mailto:avia...@dev.mellanox.co.il]
Sent: Monday, October 16, 2017 11:42 AM
To: Gonzalez Monroy, Sergio <sergio.gonzalez.mon...@intel.com>;
dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.gua...@intel.com>;
avia...@mellanox.com
Cc: bor...@mellanox.com; akhil.go...@nxp.com;
hemant.agra...@nxp.com; Nicolau, Radu <radu.nico...@intel.com>;
Doherty, Declan <declan.dohe...@intel.com>; lir...@mellanox.com;
nelio.laranje...@6wind.com; tho...@monjalon.net
Subject: Re: [dpdk-dev][PATCH 05/11] examples/ipsec-secgw: Fixed
transport
On 10/16/2017 12:30 PM, Sergio Gonzalez Monroy wrote:
On 14/10/2017 14:27, avia...@dev.mellanox.co.il wrote:
From: Aviad Yehezkel <avia...@mellanox.com>
Seems like transport was broken for a long time
Commit message needs to be improved. Just mentioned what is wrong or
how do you fix it.
Given that it is a fix, you should start the commit title with "fix
..." then also add the 'fixes' line with commit that added the bug.
That way you can easily see since when it was introduced.
Thanks,
Sergio
Will create such commit messages for future fixes as you instructed above.
I will remove this patch from next version of fixes since there is a similar fix
already provided by Tomasz Duszynski which I will review.
Thanks,
Aviad.
Hi Aviad,
Will you send a v2 of this patchset soon?
Thanks,
Pablo
