-----Original Message----- From: dev <[email protected]> on behalf of Harish Patil <[email protected]> Date: Friday, October 20, 2017 at 3:18 PM To: Ferruh Yigit <[email protected]>, Jingjing Wu <[email protected]>, "Thotton, Shijith" <[email protected]>, Gregory Etelson <[email protected]> Cc: Thomas Monjalon <[email protected]>, "[email protected]" <[email protected]>, "[email protected]" <[email protected]>, Jianfeng Tan <[email protected]>, George Prekas <[email protected]>, Sergio Gonzalez Monroy <[email protected]> Subject: Re: [dpdk-dev] [PATCH] igb_uio: remove device reset in open
>[This sender failed our fraud detection checks and may not be who they >appear to be. Learn about spoofing at http://aka.ms/LearnAboutSpoofing] > >-----Original Message----- >From: Ferruh Yigit <[email protected]> >Date: Friday, October 20, 2017 at 9:57 AM >To: Jingjing Wu <[email protected]>, "Thotton, Shijith" ><[email protected]>, Gregory Etelson <[email protected]>, Harish >Patil <[email protected]> >Cc: Thomas Monjalon <[email protected]>, "[email protected]" <[email protected]>, >"[email protected]" <[email protected]>, Jianfeng Tan ><[email protected]>, George Prekas <[email protected]>, Sergio >Gonzalez Monroy <[email protected]> >Subject: Re: [PATCH] igb_uio: remove device reset in open > >>On 10/20/2017 9:55 AM, Ferruh Yigit wrote: >>> Remove device reset during application start, the reset for application >>> exit still there. >>> >>> Reset in open removed because of following comments: >>> 1- Device reset not completed when VF driver loaded, which cause VF PMD >>> initialization error. >>> Adding delay can solve the issue but will increase driver load time. >>> >>> 2- Reset will be issues all devices unconditionally, not very efficient >>> way. >>> >>> Fixes: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of >>>device file") >>> Cc: [email protected] >>> >>> Signed-off-by: Ferruh Yigit <[email protected]> >> >>Hi Jingjing, Shijith, Gregory, Harish, >> >>Can you please test this on top of current master (which has already >>Jingjin's >>fix) ? >> >>Thanks, >>Ferruh > > >Ferruh, >Sure, will try and get back to you. >Thanks. Ferruh and all, This takes care of our SR-IOV VF issue. Thanks. >> >>> --- >>> Cc: Jianfeng Tan <[email protected]> >>> Cc: Jingjing Wu <[email protected]> >>> Cc: Shijith Thotton <[email protected]> >>> Cc: Gregory Etelson <[email protected]> >>> Cc: Harish Patil <[email protected]> >>> Cc: George Prekas <[email protected]> >>> Cc: Sergio Gonzalez Monroy <[email protected]> >>> --- >>> lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 2 -- >>> 1 file changed, 2 deletions(-) >>> >>> diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c >>>b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c >>> index f7ef82554..fd320d87d 100644 >>> --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c >>> +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c >>> @@ -336,8 +336,6 @@ igbuio_pci_open(struct uio_info *info, struct inode >>>*inode) >>> struct pci_dev *dev = udev->pdev; >>> int err; >>> >>> - pci_reset_function(dev); >>> - >>> /* set bus master, which was cleared by the reset function */ >>> pci_set_master(dev); >>> >>> >> >
