Hi Jianfeng,
> -----Original Message-----
> From: Tan, Jianfeng
> Sent: Friday, October 13, 2017 12:52 PM
> To: [email protected]
> Cc: [email protected]; Richardson, Bruce
> <[email protected]>; Ananyev, Konstantin
> <[email protected]>; De Lara Guarch, Pablo
> <[email protected]>; [email protected];
> [email protected]; [email protected];
> [email protected]; Yigit, Ferruh <[email protected]>; Tan,
> Jianfeng <[email protected]>
> Subject: [PATCH v7 3/4] bus/vdev: move to vdev bus to drivers/bus
>
> Move the vdev bus from lib/librte_eal to drivers/bus.
>
> As the crypto vdev helper function refers to data structure in rte_vdev.h, so
> we move those helper function into drivers/bus too.
I am seeing some errors with this patch, compiling the test app:
test/test/test_eventdev.c:54:10: error: implicit declaration of function
'rte_vdev_init'
[-Werror=implicit-function-declaration]
return rte_vdev_init("event_skeleton", NULL);
^~~~~~~~~~~~~
test/test/test_eventdev.c:54:3: error: nested extern declaration of
'rte_vdev_init'
[-Werror=nested-externs]
return rte_vdev_init("event_skeleton", NULL);
^~~~~~
Also, I have a couple of comments more below.
...
> +++ b/drivers/bus/vdev/rte_bus_vdev_version.map
> @@ -0,0 +1,8 @@
> +DPDK_17.11 {
> + global:
> +
> + rte_vdev_init;
> + rte_vdev_register;
> + rte_vdev_uninit;
> + rte_vdev_unregister;
These functions should be removed from rte_eal_version.map,
for Linux and BSD, right?
Also, should this be documented in release notes?
