> -----Original Message----- > From: Olivier Matz [mailto:[email protected]] > Sent: Thursday, October 12, 2017 11:04 AM > To: [email protected] > Cc: Eads, Gage <[email protected]>; [email protected]; > Richardson, Bruce <[email protected]>; > [email protected]; [email protected] > Subject: [PATCH 0/3] mk: fix LDLIBS > > Some libraries in LDLIBS are currently generated from the > DEPDIRS-$(dirname) variables in the Makefiles. This is valid when the > subdirectory name match the library name, but it's not always the case, > especially for PMDs. > > This series fixes some invalid dependency declarations first, and then removes > the automatic generation of libraries from the directory names. Instead, the > libraries are explicitly added in each Makefile. >
These three patches look good. I tested it on the contrived example from my original email, and this appears to fix the issue. Once the third patch's apply issues are resolved (http://dpdk.org/ml/archives/test-report/2017-October/032631.html): Reviewed-by: Gage Eads <[email protected]> Thanks, Gage
