> -----Original Message----- > From: David Marchand [mailto:[email protected]] > Sent: Thursday, October 26, 2017 12:39 PM > To: Ananyev, Konstantin <[email protected]> > Cc: Nicolau, Radu <[email protected]>; [email protected]; Doherty, Declan > <[email protected]>; De Lara Guarch, Pablo > <[email protected]>; Hemant Agrawal <[email protected]>; > [email protected]; [email protected]; > Thomas Monjalon <[email protected]>; [email protected]; Jerin Jacob > <[email protected]>; Mcnamara, > John <[email protected]>; [email protected]; Olivier Matz > <[email protected]>; Akhil Goyal > <[email protected]> > Subject: Re: [PATCH 2/3] net/ixgbe: fix build issue > > On Thu, Oct 26, 2017 at 1:30 PM, Ananyev, Konstantin > <[email protected]> wrote: > >> -----Original Message----- > >> From: Nicolau, Radu > >> It can be disabled in the code, but as far as I know there is a general > >> push back against having conditionally compiled code. I originally had > >> the security sections in ixgbe PMD isolated, but the feedback was to > >> have them always on. > >> An alternative solution will be to remove the option altogether and > >> always build rte_security library. > > > > My vote would be to have it a mandatory library for ixgbe. > > Add it into DEPDIRS-ixgbe inside drivers/net/Makefile or so. > > And then librte_security needs librte_crypto (if I am not mistaken).
It seems like it does... Though from what I understand - it uses inly some struct definitions from it. Wonder could we move these definitions into rte_security instead and make rte_cryptodev depend on it instead? Konstantin > So if we go this way, we must ensure the same is done in librte_security. > > > -- > David Marchand
