-----Original Message----- > Date: Mon, 30 Oct 2017 09:06:54 +0100 > From: Gaëtan Rivet <gaetan.ri...@6wind.com> > To: Jerin Jacob <jerin.ja...@caviumnetworks.com> > Cc: dev@dpdk.org, tho...@monjalon.net > Subject: Re: [dpdk-dev] [PATCH] bus/pci: fix vfio mode > User-Agent: Mutt/1.5.23 (2014-03-12) > > Hi Jerin,
Hi Gaëtan, > > On Sat, Oct 28, 2017 at 11:50:52AM +0530, Jerin Jacob wrote: > > The definition of VFIO_PRESENT is "eal_vfio.h", Fail to > > include eal_vfio.h will result in disabling vfio. > > > > Fixes: 279b581c897d ("vfio: expose functions") > > > > Thanks for the fix, sorry for VFIO. > I tried to let go of VFIO_PRESENT in the PCI patchset, unfortunately I did > not do a good-enough job. > > Instead of reinstating the dependency on the private eal_vfio.h header, > I'd suggest replacing all VFIO_PRESENT references within the PCI bus by > RTE_EAL_VFIO, and make the pci_vfio.c compilation depend on it within > the linux Makefile. Something like: That will work. But, I think, We can push this patch as a hot fix as master is broken now.