> -----Original Message-----
> From: Iremonger, Bernard
> Sent: Wednesday, November 1, 2017 12:10 PM
> To: dev@dpdk.org; Singh, Jasvinder <jasvinder.si...@intel.com>
> Cc: Iremonger, Bernard <bernard.iremon...@intel.com>
> Subject: [PATCH] examples/flow_classify: fix fseek error handling
>
> Check return value of fseek and exit if non zero.
>
> Coverity issue: 143435
>
> Fixes: bab16ddaf2c1 ("examples/flow_classify: add sample application")
> Signed-off-by: Bernard Iremonger <bernard.iremon...@intel.com>
> ---
> examples/flow_classify/flow_classify.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/examples/flow_classify/flow_classify.c
> b/examples/flow_classify/flow_classify.c
> index e4cabdb..766f1dd 100644
> --- a/examples/flow_classify/flow_classify.c
> +++ b/examples/flow_classify/flow_classify.c
> @@ -657,13 +657,17 @@ static __attribute__((noreturn)) void
> unsigned int i = 0;
> unsigned int total_num = 0;
> struct rte_eth_ntuple_filter ntuple_filter;
> + int ret;
>
> fh = fopen(rule_path, "rb");
> if (fh == NULL)
> - rte_exit(EXIT_FAILURE, "%s: Open %s failed\n", __func__,
> + rte_exit(EXIT_FAILURE, "%s: fopen %s failed\n", __func__,
> rule_path);
>
> - fseek(fh, 0, SEEK_SET);
> + ret = fseek(fh, 0, SEEK_SET);
> + if (ret)
> + rte_exit(EXIT_FAILURE, "%s: fseek %d failed\n", __func__,
> + ret);
>
> i = 0;
> while (fgets(buff, LINE_MAX, fh) != NULL) {
> --
> 1.9.1
Acked-by: Jasvinder Singh <jasvinder.si...@intel.com>
