More error reported for device reset in release() [1], when device pass-through to the guest, host kernel crash on guest exit.
Removing the reset completely. [1] http://dpdk.org/ml/archives/dev/2017-November/081459.html Fixes: e3a64deae2d5 ("igb_uio: prevent reset for bnx2x devices") Fixes: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of device file") Cc: sta...@dpdk.org Signed-off-by: Ferruh Yigit <ferruh.yi...@intel.com> --- Cc: Jianfeng Tan <jianfeng....@intel.com> Cc: Jingjing Wu <jingjing...@intel.com> Cc: Shijith Thotton <shijith.thot...@caviumnetworks.com> Cc: Gregory Etelson <greg...@weka.io> Cc: Harish Patil <harish.pa...@cavium.com> Cc: George Prekas <george.pre...@epfl.ch> Cc: Sergio Gonzalez Monroy <sergio.gonzalez.mon...@intel.com> Cc: Rasesh Mody <rasesh.m...@cavium.com> Cc: Lee Roberts <lee.robe...@hpe.com> Cc: Stephen Hemminger <step...@networkplumber.org> Cc: Chas Williams <ch...@att.com> --- lib/librte_eal/linuxapp/igb_uio/compat.h | 19 ------------------- lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 8 -------- 2 files changed, 27 deletions(-) diff --git a/lib/librte_eal/linuxapp/igb_uio/compat.h b/lib/librte_eal/linuxapp/igb_uio/compat.h index c8b2c9de3..ce456d4bb 100644 --- a/lib/librte_eal/linuxapp/igb_uio/compat.h +++ b/lib/librte_eal/linuxapp/igb_uio/compat.h @@ -132,22 +132,3 @@ static bool pci_check_and_mask_intx(struct pci_dev *pdev) #if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 5, 0) #define HAVE_PCI_MSI_MASK_IRQ 1 #endif - -#define BROADCOM_PCI_VENDOR_ID 0x14E4 -static const struct pci_device_id no_reset_pci_tbl[] = { - { PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x164f) }, /* 57711 */ - { PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x168a) }, /* 57800 */ - { PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x168e) }, /* 57810 */ - { PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x163d) }, /* 57811 */ - { PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x168d) }, /* 57840_OBS */ - { PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x16a1) }, /* 57840_4_10 */ - { PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x16a2) }, /* 57840_2_20 */ - { PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x16ae) }, /* 57810_MF */ - { PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x163e) }, /* 57811_MF */ - { PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x16a4) }, /* 57840_MF */ - { PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x16a9) }, /* 57800_VF */ - { PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x16af) }, /* 57810_VF */ - { PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x163f) }, /* 57811_VF */ - { PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, 0x16ad) }, /* 57840_VF */ - { 0 }, -}; diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c index 037e02267..a3a98c173 100644 --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c @@ -348,11 +348,6 @@ igbuio_pci_open(struct uio_info *info, struct inode *inode) return 0; } -static bool is_device_excluded_from_reset(struct pci_dev *pdev) -{ - return !!pci_match_id(no_reset_pci_tbl, pdev); -} - static int igbuio_pci_release(struct uio_info *info, struct inode *inode) { @@ -365,9 +360,6 @@ igbuio_pci_release(struct uio_info *info, struct inode *inode) /* stop the device from further DMA */ pci_clear_master(dev); - if (!is_device_excluded_from_reset(dev)) - pci_reset_function(dev); - return 0; } -- 2.13.6
