> -----Original Message----- > From: Stephen Hemminger [mailto:[email protected]] > Sent: Thursday, November 30, 2017 10:59 AM > To: Wang, Xiao W <[email protected]> > Cc: [email protected]; [email protected] > Subject: Re: [dpdk-dev] [PATCH 1/2] net/virtio: make control queue thread- > safe > > On Fri, 24 Nov 2017 03:03:59 -0800 > Xiao Wang <[email protected]> wrote: > > > @@ -184,8 +186,10 @@ struct rte_virtio_xstats_name_off { > > "vq->hw->cvq = %p vq = %p", > > vq->vq_desc_head_idx, status, vq->hw->cvq, vq); > > > > - if ((vq->vq_free_cnt < ((uint32_t)pkt_num + 2)) || (pkt_num < 1)) > > + if ((vq->vq_free_cnt < ((uint32_t)pkt_num + 2)) || (pkt_num < 1)) { > > You ndon't need so many paranthesis. > if (vq->vq_free_cnt < pkt_num + 2 || pkt_num < 1)
Yes, it looks better. Will change it in v2. Thanks, Xiao
