On 11/19/2017 6:41 AM, Ilya Matveychikov wrote: > > >> On Nov 19, 2017, at 12:18 PM, Ilya Matveychikov <[email protected]> >> wrote: >> >> Update RTE_VERIFY macro to make it possible to use complex expressions >> in RTE_ASSERT. >> >> Signed-off-by: Ilya V. Matveychikov <[email protected]> >> >> Fixes: 148f963fb532 ("xen: core library changes") >> Cc: [email protected] >> >> --- >> Now it's incorrect to use complex expressions for assertion >> like RTE_ASSERT((1 + 2) == 3). This patch makes it possible. > > Update. > > Now it’s possible to have % char inside the expression, for example: > > RTE_ASSERT((sizeof(some_struct) % 64) == 0) > > Before the patch, “%" sign acts like a conversion specification beginning > character.
previous sample is not correct, complex expressions "RTE_ASSERT((1 + 2) == 3)" are working fine. But you are right "%" causing problem, and this patch is fixing it. Reviewed-by: Ferruh Yigit <[email protected]>
