> From: Pavan Nikhilesh [mailto:[email protected]]
> Sent: Thursday, December 14, 2017 3:02 PM
> To: [email protected]; [email protected];
> Richardson, Bruce <[email protected]>; Van Haaren, Harry
> <[email protected]>; Eads, Gage <[email protected]>;
> [email protected]; [email protected]; Ma, Liang J
> <[email protected]>

[Side note: we shouldn't put everybody on CC all the time..]

> Cc: [email protected]; Pavan Nikhilesh <[email protected]>
> Subject: [dpdk-dev] [PATCH v2 10/11] test: register eventdev selftest
> 
> Signed-off-by: Pavan Nikhilesh <[email protected]>


> diff --git a/test/test/test_eventdev.c b/test/test/test_eventdev.c
> index 1ed2a1ddd..b86efab01 100644
> --- a/test/test/test_eventdev.c
> +++ b/test/test/test_eventdev.c
> @@ -1009,4 +1009,11 @@ test_eventdev_common(void)
>       return unit_test_suite_runner(&eventdev_common_testsuite);
>  }
> 
> +static int
> +test_eventdev_selftest(void)
> +{
> +     return rte_event_dev_selftest(TEST_DEV_ID);
> +}
> +
>  REGISTER_TEST_COMMAND(eventdev_common_autotest, test_eventdev_common);
> +REGISTER_TEST_COMMAND(eventdev_selftest, test_eventdev_selftest);


Currently when running the test app, we don't pass any arguments. Running the 
"eventdev_sw_autotest" command, it will create the required event_sw0 PMD vdev, 
and launch the tests then.

Given the selftest is PMD agnostic, does it makes sense to have a single string 
"sw" or "octeontx" to run the tests against? Right now it requires that we pass 
./app/test --vdev event_sw0  which I think is a burden, particularly when 
automating this with the meson test infrastructure down the line.

Summary; Please add a string parameter that indicates the PMD to run the 
self-test on.

Reply via email to