-----Original Message-----
From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jonas
Pfefferle1
Sent: Wednesday, November 8, 2017 7:52 PM
To: Burakov, Anatoly <anatoly.bura...@intel.com>
Cc: dev@dpdk.org; jianfeng....@intel.com; Thomas Monjalon
<tho...@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH] mem: warn if address hint is not
respected
"Burakov, Anatoly" <anatoly.bura...@intel.com> wrote on 11/07/2017
02:54:24
PM:
> From: "Burakov, Anatoly" <anatoly.bura...@intel.com>
> To: Thomas Monjalon <tho...@monjalon.net>
> Cc: dev@dpdk.org, Jonas Pfefferle <j...@zurich.ibm.com>,
jianfeng....@intel.com
> Date: 11/07/2017 02:54 PM
> Subject: Re: [dpdk-dev] [PATCH] mem: warn if address hint is not
respected
>
> On 06-Nov-17 8:26 PM, Thomas Monjalon wrote:
> > 31/10/2017 10:08, Jonas Pfefferle:
> >> Print a warning if the --base-virtaddr hint is not respected
since
> >> this might lead to problems when mapping memory in the
secondary
> >> process.
> >>
> >> Signed-off-by: Jonas Pfefferle <j...@zurich.ibm.com>
> >
> > Anatoly, please review this patch.
> > It does not seem to fix something, so it is candidate for 18.02.
> >
>
> For some reason my Thunderbird ate the original email, so i'll
reply
> to this one.
>
> One nitpick would be that we're calling get_virtual_area many
times
> and it would probably be a good idea to make pagesize static and
call
> sysconf only once. Otherwise,
We should address this in a separate patch and introduce a pagesize
function for everyone to use. sysconf is used like this all over the
place.
>
> Acked-by: Anatoly Burakov <anatoly.bura...@intel.com>
>
> --
> Thanks,
> Anatoly
>