Hi, On Fri, Dec 29, 2017 at 09:07:49AM -0800, Stephen Hemminger wrote: > On Tue, 21 Nov 2017 01:42:37 +0000 > Ferruh Yigit <ferruh.yi...@intel.com> wrote: > > > To track modification: > > 8f094a9ac5d7 ("mbuf: set mbuf fields while in pool") > > > > Proposed deadline for PMDs is v18.02 > > > > Signed-off-by: Ferruh Yigit <ferruh.yi...@intel.com> > > --- > > doc/guides/nics/todo.rst | 19 ++++++++++++++----- > > 1 file changed, 14 insertions(+), 5 deletions(-) > > > > diff --git a/doc/guides/nics/todo.rst b/doc/guides/nics/todo.rst > > index 874811ad5..b408fc691 100644 > > --- a/doc/guides/nics/todo.rst > > +++ b/doc/guides/nics/todo.rst > > @@ -36,8 +36,17 @@ This is the list for tracking required PMD changes > > triggered by library modifica > > > > .. table:: PMDs internal TODO list > > > > - +------+------+----------+----------------+------+ > > - | TODO | PMDs | Deadline | Related Commit | Note | > > - +======+======+==========+================+======+ > > - | | | | | | > > - +------+------+----------+----------------+------+ > > + > > +-------------------+--------------------------------+----------+----------------+-----------------------------------+ > > + | TODO | PMDs | Deadline | Related > > Commit | Note | > > + > > +===================+================================+==========+================+===================================+ > > + | mbuf organisation | | af_packet, ark, avp, bnx2x, | v18.02 | > > 8f094a9ac5d7 | Remove unnecessary mbuf field | > > + | | | bnxt, bonding, cxgbe, dpaa, | | > > | initialization. | > > + | | | dpaa2, e1000, ena, | | > > | | > > + | | | failsafe, fm10k, | | > > | | > > + | | | kni, mlx4, | | > > | | > > + | | | mrvl, nfp, octeontx, | | > > | | > > + | | | pcap, qede, ring, sfc, | | > > | | > > + | | | softnic, szedata2, tap, | | > > | | > > + | | | thunderx, vhost, | | > > | | > > + | | | vmxnet3 | | > > | | > > + > > +-------------------+--------------------------------+----------+----------------+-----------------------------------+ > > NAK > > This open source, if the fix is trivial please just fix all the drivers > directly now. > These TODO lists never get done.
The fix is not that trivial, especially for vector PMDs. It can also impact performance. It looks dangerous for me to blindly do a patch without any hardware to do the test.