> -----Original Message----- > From: Nicolau, Radu > Sent: Tuesday, December 12, 2017 12:50 PM > To: [email protected] > Cc: Ananyev, Konstantin <[email protected]>; Yigit, Ferruh > <[email protected]>; Gonzalez Monroy, Sergio > <[email protected]>; De Lara Guarch, Pablo > <[email protected]>; Doherty, Declan > <[email protected]>; [email protected]; Nicolau, Radu > <[email protected]> > Subject: [PATCH 2/3] net/ixgbe: implemented security session get size
Use "implement" in infinitive. > > Signed-off-by: Radu Nicolau <[email protected]> > --- > drivers/net/ixgbe/ixgbe_ipsec.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/net/ixgbe/ixgbe_ipsec.c > b/drivers/net/ixgbe/ixgbe_ipsec.c index 105da11..720d6a1 100644 > --- a/drivers/net/ixgbe/ixgbe_ipsec.c > +++ b/drivers/net/ixgbe/ixgbe_ipsec.c > @@ -446,6 +446,12 @@ ixgbe_crypto_create_session(void *device, } > > static int > +ixgbe_crypto_session_get_size(__rte_unused void *device) { Do you think passing device to the function prototype is needed? Are you expecting other drivers to use it? Also, move the braces to a new line (both opening and ending). > + return sizeof(struct ixgbe_crypto_session); } > + Thanks, Pablo
