So, how can separate the patch into more small patch, use stake or null implement in function. I think we should consider if it is a economic way now, if I could explain more detail in code for you all not very familiar the background? I have sent v8, please check, thanks all.
Best regards, Jeff Guo -----Original Message----- From: Thomas Monjalon [mailto:[email protected]] Sent: Tuesday, January 9, 2018 6:48 PM To: Guo, Jia <[email protected]> Cc: Mordechay Haimovsky <[email protected]>; [email protected]; [email protected]; Richardson, Bruce <[email protected]>; Yigit, Ferruh <[email protected]>; [email protected]; Ananyev, Konstantin <[email protected]>; [email protected]; Wu, Jingjing <[email protected]>; Zhang, Helin <[email protected]>; Van Haaren, Harry <[email protected]> Subject: Re: [dpdk-dev] [PATCH v7 1/2] eal: add uevent monitor for hot plug 09/01/2018 11:31, Mordechay Haimovsky: > From: Guo, Jia [mailto:[email protected]] > > On 1/9/2018 8:39 AM, Thomas Monjalon wrote: > > > At last there is the kernel binding effort - this one will > > > probably be ignored for 18.02, because it is another huge topic. > > > Without bothering with kernel binding, we can at least remove a > > > device, get a notification, and eventually re-add it. It is a good first > > > step. > > > Anyway your testpmd patch tests exactly this scenario (totally new > > > devices are not seen). > > > > i will separate it for you all to benefit for review. for kernel > > binding, i just let it automatically compare with the first time > > manually binding, and it is the part of he hot plug flow. so i > > suggest to review more about that if it is not side effect and workable, > > beg for keep on. > > This will not work for Mellanox which uses several drivers and > services in order to map the device and device queues to user space. > For example, the mlx4 PMD (PMD for ConnectX-3 devices) requires that > mlx4_core mlx4_en and mlx4_ib drivers to be loaded, and for RDM -core > user-space libraries and daemons to be loaded. Yes automatic binding is a feature which requires more work. It cannot be ready for 18.02.
