> From: Eads, Gage > Sent: Tuesday, January 9, 2018 4:20 PM > To: [email protected] > Cc: [email protected]; Van Haaren, Harry > <[email protected]>; [email protected]; > [email protected] > Subject: [PATCH] event/sw: remove stale IQ references when reconfigured > > This commit fixes a bug in which, when the sw PMD is reconfigured, it would > leave stale IQ chunk pointers in each queue's IQ structure. Now, the PMD > initializes all IQs at eventdev start time and releases all IQ chunk > pointers at eventdev stop time (which has the consequence that any events > in a queue when the eventdev is stopped will be lost). This approach should > be resilient to any reconfiguration done between the stop and start, such > as adding or removing queues. > > This commit also fixes two potential issues in iq_chunk.h. iq_init() > now initializes the IQ's count field to 0, and iq_dequeue_burst() sets > iq->head to the appropriate next pointer. > > Fixes: 5b5e476e59a4 ("event/sw: use dynamically-sized IQs") > Signed-off-by: Gage Eads <[email protected]>
After reproducing the error reliably, I can confirm this patch fixes here. Also, I think this patch deserves a reported by tag. Perhaps it can be added on apply? Reported-By: Pavan Nikhilesh <[email protected]> @Pavan, as the reporter, would you double check please? With a +1 / Ack from Pavan, lets merge this :) Reviewed-by: Harry van Haaren <[email protected]>
