> -----Original Message-----
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Harry van Haaren
> Sent: Thursday, December 21, 2017 12:08 PM
> To: dev@dpdk.org
> Cc: tho...@monjalon.net; Richardson, Bruce
> <bruce.richard...@intel.com>; Van Haaren, Harry
> <harry.van.haa...@intel.com>
> Subject: [dpdk-dev] [PATCH 2/2] test: add skip instead of fail, update crypto
> test
>
> This commit adds a SKIPPED return value from the unit tests, indicating that
> the test was not able to run (eg: PMD was not enabled when DPDK was
> compiled).
>
> The cryptodev tests are updated to return SKIPPED instead of failing if the
> PMD is not enabled, allowing any test infrastructure to identify that the test
> was not able to run.
Check-git-log.sh complains about the commit title (because of the comma).
I think this patch should be split into two patches: one that adds TEST_SKIPPED
and another one that updates the crypto tests (the title suggests these two
patches).
Also, when running a test that returns TEST_SKIPPED, it still prints out "Test
Failed".
It looks like this is caused because cmd_autotest_parsed() hasn't been updated:
static void cmd_autotest_parsed(void *parsed_result,
__attribute__((unused)) struct cmdline *cl,
__attribute__((unused)) void *data)
{
...
if (ret == 0)
printf("Test OK\n");
else
printf("Test Failed\n");
Probably, another check should be added here.
Pablo
