> On Jan 17, 2018, at 10:06 AM, Yigit, Ferruh <ferruh.yi...@intel.com> wrote: > > On 12/21/2017 1:38 PM, Wiles, Keith wrote: >> >> >>> On Dec 21, 2017, at 10:53 AM, Vipin Varghese <vipin.vargh...@intel.com> >>> wrote: >>> >>> TAP speed is passed as user argument, but never set to interface. >>> New logic brings speed get and set to LOCAL and REMOTE interfaces. >>> >>> Updated the default PMD speeed to 10M as per Linux Kernel default >>> value. >> >> The problem in setting the link speed to 10M is that TAP will not limit its >> traffic to 10M. Applications like pktgen and others use the Link speed to >> calculate the bit rate, which will be broken now. >> >> I would suggest making the default value 10G or 40G instead as CPU speeds >> will continue to increase. Forcing someone to always add the link speed >> seems a bit much when we know the systems can send/receive much higher then >> 10M, which is the reason 10G was picked. Please set the default back to 10G >> or some much higher number. > > Hi Keith, Vipin, Pascal, > > Since we really can't set the interface for Linux tap interface, what do you > think removing speed arg completely from tap PMD?
I have no problems with it being remove from the PMD. The only problem is this being a virtual interface it can be any speed, but 10M is unreasonable IMO. I would like it to be set to something reasonable as the default (40G or 10G) or would zero be more reasonable. I know the reported speed does not effect the performance, but tools that look at the speed and attempt to use that speed need a value greater then the max bit rate of the interface IMO. If we had a value to indicate a bogus speed then maybe the tools can adjust in some way. > > Thanks, > ferruh > >> >>> >>> Signed-off-by: Vipin Varghese <vipin.vargh...@intel.com> >>> --- >>> drivers/net/tap/rte_eth_tap.c | 185 >>> +++++++++++++++++++++++++++++++++++++++++- >>> 1 file changed, 182 insertions(+), 3 deletions(-) >>> >>> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c >>> index 6b27679..7238504 100644 >>> --- a/drivers/net/tap/rte_eth_tap.c >>> +++ b/drivers/net/tap/rte_eth_tap.c >>> @@ -62,6 +62,8 @@ >>> #include <linux/if_ether.h> >>> #include <linux/version.h> >>> #include <fcntl.h> >>> +#include <linux/ethtool.h> >>> +#include <linux/sockios.h> >>> >> >> Regards, >> Keith Regards, Keith
