Wednesday, January 17, 2018 7:33 PM, Thomas Monjalon:
09:12, Andrew Rybchenko:
> > From: Ivan Malov <ivan.ma...@oktetlabs.ru>
> >
> > +#define RTE_RX_OFFLOAD_BIT2STR(_name) \
> > + { DEV_RX_OFFLOAD_##_name, #_name }
> > +
> > +static const struct {
> > + uint64_t offload;
> > + const char *name;
> > +} rte_rx_offload_names[] = {
> > + RTE_RX_OFFLOAD_BIT2STR(VLAN_STRIP),
> > + RTE_RX_OFFLOAD_BIT2STR(IPV4_CKSUM),
> > + RTE_RX_OFFLOAD_BIT2STR(UDP_CKSUM),
> > + RTE_RX_OFFLOAD_BIT2STR(TCP_CKSUM),
> > + RTE_RX_OFFLOAD_BIT2STR(TCP_LRO),
> > + RTE_RX_OFFLOAD_BIT2STR(QINQ_STRIP),
> > + RTE_RX_OFFLOAD_BIT2STR(OUTER_IPV4_CKSUM),
> > + RTE_RX_OFFLOAD_BIT2STR(MACSEC_STRIP),
> > + RTE_RX_OFFLOAD_BIT2STR(HEADER_SPLIT),
> > + RTE_RX_OFFLOAD_BIT2STR(VLAN_FILTER),
> > + RTE_RX_OFFLOAD_BIT2STR(VLAN_EXTEND),
> > + RTE_RX_OFFLOAD_BIT2STR(JUMBO_FRAME),
> > + RTE_RX_OFFLOAD_BIT2STR(CRC_STRIP),
> > + RTE_RX_OFFLOAD_BIT2STR(SCATTER),
> > + RTE_RX_OFFLOAD_BIT2STR(TIMESTAMP),
> > + RTE_RX_OFFLOAD_BIT2STR(SECURITY),
> > +};
> > +
> > +#undef RTE_RX_OFFLOAD_BIT2STR
>
> Why this undef?
>
> > --- a/lib/librte_ether/rte_ethdev_version.map
> > +++ b/lib/librte_ether/rte_ethdev_version.map
> > @@ -198,6 +198,12 @@ DPDK_17.11 {
> >
> > } DPDK_17.08;
> >
> > +DPDK_18.02 {
> > + global:
> > +
> > + rte_eth_dev_rx_offload_name;
> > +} DPDK_17.11;
>
> New functions should be experimental.
>
> > EXPERIMENTAL {
> > global:
Apart from Thomas comments looks OK to me.
