Thank you, Thomas, I will do that according to your comments. Thanks Zhiyong
> -----Original Message----- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Friday, January 19, 2018 5:38 PM > To: Yang, Zhiyong <zhiyong.y...@intel.com> > Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yi...@intel.com>; > olivier.m...@6wind.com > Subject: Re: [PATCH] lib/librte_mbuf: remove void * pointer cast > > Hi Zhiyong, > > 3 comments about patch formatting: > > 1/ the title must follow the convention seen in the git history. > If you use git log --oneline lib/librte_mbuf you will see that it must start > with > "mbuf:" > > 2/ The * character does not play well when patch saved in a file, and it is > useless: "void pointer" is correct for understanding. > > 3/ You must Cc the maintainer as described in MAINTAINERS. > You can use devtools/get-maintainer.sh. > Here, I Cc Olivier. > > Thanks > > > 19/01/2018 10:12, Zhiyong Yang: > > It is unnecessary to cast from void * to struct rte_mbuf *, the change > > can make code more simple. > > > > Signed-off-by: Zhiyong Yang <zhiyong.y...@intel.com>
