I add this code line to align same style and same action taken in ixgbe VF and i40e VF. In ixgbe VF or i40e VF, without this line, the initialization of Rx queue interrupt mapping to VFIO-PCI vectors would fail. I have tested it in ixgbe PF port with example/l3fwd-power and found the interrupt can be initialized successfully and Rx queue can be waked up by incoming packets no matter whether this line exists or not. So I decide to reject it now.
> -----Original Message----- > From: Yang, Qiming > Sent: Wednesday, January 10, 2018 2:29 PM > To: Lu, Wenzhuo <wenzhuo...@intel.com>; Dai, Wei <wei....@intel.com> > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] net/ixgbe: fix VFIO interrupt mapping in PF > > +1 why we disable interrupt in dev_start twice? > > > -----Original Message----- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wenzhuo Lu > > Sent: Tuesday, January 9, 2018 4:24 PM > > To: Dai, Wei <wei....@intel.com> > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] net/ixgbe: fix VFIO interrupt mapping in PF > > > > Hi Wei, > > > > > + rte_intr_disable(intr_handle); > > TBH, confused by this patch. I see the intr already disabled at the > > begining of this function, ixgbe_dev_start, why we need to disable it > again?
