> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Thursday, January 25, 2018 1:11 PM
> To: Xing, Beilei <beilei.x...@intel.com>
> Cc: dev@dpdk.org; Zhao1, Wei <wei.zh...@intel.com>; Zhang, Qi Z
> <qi.z.zh...@intel.com>
> Subject: [PATCH] net/i40e: fix bug in RSS flow action parser
> 
> Parameter action_flag is not used correctly in i40e_flow_parse_rss_action.
> Also change it from point type to value type since it is not an output
> parameter.
> 
> Fixes: ecad87d22383e ("net/i40e: move RSS to flow API")
> 
> Signed-off-by: Qi Zhang <qi.z.zh...@intel.com>
> ---
>  drivers/net/i40e/i40e_flow.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c
> index a74fa08ab..74708f168 100644
> --- a/drivers/net/i40e/i40e_flow.c
> +++ b/drivers/net/i40e/i40e_flow.c
> @@ -4188,7 +4188,7 @@ static int
>  i40e_flow_parse_rss_action(struct rte_eth_dev *dev,
>                           const struct rte_flow_action *actions,
>                           struct rte_flow_error *error,
> -                         uint8_t *action_flag,
> +                         uint8_t action_flag,
>                           struct i40e_queue_regions *conf_info,
>                           union i40e_filter_t *filter)
>  {
> @@ -4378,7 +4378,7 @@ i40e_parse_rss_filter(struct rte_eth_dev *dev,
>               return ret;
> 
>       ret = i40e_flow_parse_rss_action(dev, actions, error,
> -                                     &action_flag, &info, filter);
> +                                     action_flag, &info, filter);
>       if (ret)
>               return ret;
> 
> --
> 2.13.6

Acked-by Wei Zhao <wei.zh...@intel.com>

Reply via email to