-----Original Message----- > Date: Sat, 10 Feb 2018 12:02:24 +0000 > From: Hemant Agrawal <hemant.agra...@nxp.com> > To: Jerin Jacob <jerin.ja...@caviumnetworks.com>, "dev@dpdk.org" > <dev@dpdk.org> > Subject: RE: [dpdk-dev] [PATCH] net/dpaa2: remove unused global variable > > > -----Original Message----- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jerin Jacob > > Sent: Saturday, February 10, 2018 5:28 PM > > To: dev@dpdk.org > > Cc: Jerin Jacob <jerin.ja...@caviumnetworks.com>; Hemant Agrawal > > <hemant.agra...@nxp.com> > > Subject: [dpdk-dev] [PATCH] net/dpaa2: remove unused global variable > > Importance: High > > > > Due to the missing __packed definition, compiler treating it as as global > > variable. > > > > > #grep "Allocating common symbols" -A 100 build/app/testacl.map > > __packed 0x8 /build/lib/librte_pmd_dpaa2.a(dpaa2_rxtx.o) > > [Hemant] Which compiler, you mean you faced issue with testacl app?
arm64 gcc. Not specific to testacl. We were getting minor performance regression (<1%) with l3fwd after the following change set. http://dpdk.org/dev/patchwork/patch/34709/ I don't think, the above change set directly has anything due to issue. I was chasing that issue and found that global variables has something due to with change.Most probably because it has indirect effect of changing the complete address generated in the binary and thus showing up some cached alignment related artifacts. > > > > > Fixes: a5fc38d422a7 ("net/dpaa2: support Rx packet parsing") > > > > Cc: hemant.agra...@nxp.com > > Signed-off-by: Jerin Jacob <jerin.ja...@caviumnetworks.com> > > --- > > drivers/net/dpaa2/base/dpaa2_hw_dpni_annot.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Acked-by: Hemant Agrawal <hemant.agra...@nxp.com> > > <snip>....
