> -----Original Message-----
> From: Varghese, Vipin
> Sent: Monday, February 26, 2018 4:30 PM
> To: dev@dpdk.org; Pattan, Reshma <reshma.pat...@intel.com>
> Cc: Mcnamara, John <john.mcnam...@intel.com>; Varghese, Vipin
> <vipin.vargh...@intel.com>
> Subject: [PATCH] app/pdump: check for ports
>
> In case of application build with shared library mode unless option '-d' is
> passed, poll mode driver for devices is not initialized. Notifying the user
> just
> after rte_eal_init is pro active way of intimating the user.
>
> Signed-off-by: Vipin Varghese <vipin.vargh...@intel.com>
> ---
> app/pdump/main.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/app/pdump/main.c b/app/pdump/main.c index f6865bd..4242a19
> 100644
> --- a/app/pdump/main.c
> +++ b/app/pdump/main.c
> @@ -863,6 +863,9 @@ struct parse_val {
> if (diag < 0)
> rte_panic("Cannot init EAL\n");
>
> + if (rte_eth_dev_count() == 0)
> + rte_exit(EXIT_FAILURE, "Failed to fetch ports for PDUMP!\n");
> +
Good one, can you just change the failure log to rte_exit(EXIT_FAILURE, "No
Ethernet ports - bye\n");
As, I see most of the other examples and apps do use the similar check and log
as above. :-)
Thanks,
Reshma
