Re: [dpdk-dev] [PATCH v2 39/41] net/qede: use contiguous allocation for DMA memory

[Patil, Harish]

-----Original Message-----
From: Anatoly Burakov <anatoly.bura...@intel.com>
Date: Wednesday, March 7, 2018 at 8:57 AM
To: "dev@dpdk.org" <dev@dpdk.org>
Cc: "Mody, Rasesh" <rasesh.m...@cavium.com>, Harish Patil
<harish.pa...@cavium.com>, "Shaikh, Shahed" <shahed.sha...@cavium.com>,
"keith.wi...@intel.com" <keith.wi...@intel.com>, "jianfeng....@intel.com"
<jianfeng....@intel.com>, "andras.kov...@ericsson.com"
<andras.kov...@ericsson.com>, "laszlo.vadk...@ericsson.com"
<laszlo.vadk...@ericsson.com>, "benjamin.wal...@intel.com"
<benjamin.wal...@intel.com>, "bruce.richard...@intel.com"
<bruce.richard...@intel.com>, "tho...@monjalon.net" <tho...@monjalon.net>,
"konstantin.anan...@intel.com" <konstantin.anan...@intel.com>,
"kuralamudhan.ramakrish...@intel.com"
<kuralamudhan.ramakrish...@intel.com>, "louise.m.d...@intel.com"
<louise.m.d...@intel.com>, "nelio.laranje...@6wind.com"
<nelio.laranje...@6wind.com>, "ys...@mellanox.com" <ys...@mellanox.com>,
"peppe...@japf.ch" <peppe...@japf.ch>, "Jacob,  Jerin"
<jerin.jacobkollanukka...@cavium.com>, "hemant.agra...@nxp.com"
<hemant.agra...@nxp.com>, "olivier.m...@6wind.com" <olivier.m...@6wind.com>
Subject: [PATCH v2 39/41] net/qede: use contiguous allocation for DMA
memory

>Signed-off-by: Anatoly Burakov <anatoly.bura...@intel.com>
>---
>
>Notes:
>    Doing "grep -R rte_memzone_reserve drivers/net/qede" returns the
>following:
>    
>    drivers/net/qede/qede_fdir.c:     mz =
>rte_memzone_reserve_aligned(mz_name, QEDE_MAX_FDIR_PKT_LEN,
>    drivers/net/qede/base/bcm_osal.c: mz =
>rte_memzone_reserve_aligned_contig(mz_name, size,
>    drivers/net/qede/base/bcm_osal.c: mz =
>rte_memzone_reserve_aligned_contig(mz_name, size, socket_id, 0,
>    
>    I took a brief look at memzone in qede_fdir and it didn't look like
>memzone
>    was used for DMA, so i left it alone. Corrections welcome.

That’s right.
>
> drivers/net/qede/base/bcm_osal.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/net/qede/base/bcm_osal.c
>b/drivers/net/qede/base/bcm_osal.c
>index fe42f32..707d553 100644
>--- a/drivers/net/qede/base/bcm_osal.c
>+++ b/drivers/net/qede/base/bcm_osal.c
>@@ -135,7 +135,7 @@ void *osal_dma_alloc_coherent(struct ecore_dev *p_dev,
>       if (core_id == (unsigned int)LCORE_ID_ANY)
>               core_id = 0;
>       socket_id = rte_lcore_to_socket_id(core_id);
>-      mz = rte_memzone_reserve_aligned(mz_name, size,
>+      mz = rte_memzone_reserve_aligned_contig(mz_name, size,
>                                        socket_id, 0, RTE_CACHE_LINE_SIZE);
>       if (!mz) {
>               DP_ERR(p_dev, "Unable to allocate DMA memory "
>@@ -174,7 +174,8 @@ void *osal_dma_alloc_coherent_aligned(struct
>ecore_dev *p_dev,
>       if (core_id == (unsigned int)LCORE_ID_ANY)
>               core_id = 0;
>       socket_id = rte_lcore_to_socket_id(core_id);
>-      mz = rte_memzone_reserve_aligned(mz_name, size, socket_id, 0, align);
>+      mz = rte_memzone_reserve_aligned_contig(mz_name, size, socket_id, 0,
>+                      align);
>       if (!mz) {
>               DP_ERR(p_dev, "Unable to allocate DMA memory "
>                      "of size %zu bytes - %s\n",
>-- 
>2.7.4

Acked-by: Harish Patil <harish.pa...@cavium.com>

>