> -----Original Message----- > From: Andrew Rybchenko [mailto:[email protected]] > Sent: Wednesday, March 21, 2018 12:34 PM > To: Ananyev, Konstantin <[email protected]>; Shahaf Shuler > <[email protected]>; Yigit, Ferruh > <[email protected]>; Mcnamara, John <[email protected]>; > Kovacevic, Marko <[email protected]> > Cc: [email protected]; Thomas Monjalon <[email protected]>; [email protected]; > Harish <[email protected]>; Ivan Malov > <[email protected]> > Subject: Re: [dpdk-dev] [PATCH] doc: update new ethdev offload API description > > On 03/21/2018 03:03 PM, Ananyev, Konstantin wrote: > > Hi everyone, > > > >> -----Original Message----- > >> From: dev [mailto:[email protected]] On Behalf Of Andrew Rybchenko > >> Sent: Wednesday, March 21, 2018 11:37 AM > >> To: Shahaf Shuler <[email protected]>; Yigit, Ferruh > >> <[email protected]>; Mcnamara, John <[email protected]>; > >> Kovacevic, Marko <[email protected]> > >> Cc: [email protected]; Thomas Monjalon <[email protected]>; [email protected]; > >> Harish <[email protected]>; Ivan Malov > >> <[email protected]> > >> Subject: Re: [dpdk-dev] [PATCH] doc: update new ethdev offload API > >> description > >> > >> On 03/21/2018 02:23 PM, Shahaf Shuler wrote: > >>> Wednesday, March 21, 2018 1:20 PM, *:*Andrew Rybchenko > >>> > >>>> Not exactly. We should add statement to allow to enable queue offloads > >>>> on port level (to enable on all queues). > >>> Why it is needed ? > >>> > >> May be just a paranoia to avoid misreading/misunderstanding. > >> > >>> Queue offload is also a port offload, for the simple case it is > >>> enabled on each of the queues. > >>> > >>> PMDs should report rx[tx]_offload_capa = port_offloads | queue_offloads > >>> > >>> So from the application side it enables a **port** offload which, by > >>> definition, will set the offload to each of the queues. > >>> > >>> it is not “enabling queue offload on the port”. > >>> > >> I think it would be really useful for understanding to highlight > >> that what is enabled on port level is enabled on all queues > >> regardless queue conf. > > Why not to allow queue offloads to override port offload for given queue? > > Basically it returns us to the initial point made by Ferruh: > If device has no queue offloads, but application still has to repeat > port offloads in queue offloads.
If device doesn't have per queue offloads (only per port) then there should be nothing to enable/disable per queue, no? Or you'd like to allow at queue_setup() to enable/disable port offloads too?
