Monday, March 26, 2018 3:31 PM, Thomas Monjalon: > 26/03/2018 13:54, Adrien Mazarguil: > > On Mon, Mar 26, 2018 at 12:38:22PM +0100, Ferruh Yigit wrote: > > > On 3/25/2018 9:19 PM, Ophir Munk wrote: > > > > Previous to this commit mlx4 CRC stripping was executed by default > > > > and there was no verbs API to disable it. > > > > > > Are you aware of the discussion about CRC [1]? Is this patch compatible > with plans? > > > > > > [1] > > > > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fd > > > > pdk.org%2Fdev%2Fpatchwork%2Fpatch%2F36415%2F&data=02%7C01%7Csh > ahafs% > > > > 40mellanox.com%7C90c78c02ec954cc1dfda08d59315619f%7Ca652971c7d2e4 > d9b > > > > a6a4d149256f461b%7C0%7C0%7C636576642435977344&sdata=broGz4U2Kw1 > u9xJk > > > t%2FryP7j2CU9XN0GnM5jsUxHwiNg%3D&reserved=0 > > > > I wasn't aware of this notice. Looks like it makes this patch > > unnecessary since mlx4 always strip by default; this patch makes it > > configurable at will and only exposes the capability when HW supports > > its configuration (i.e. the ability to leave CRC inside mbuf). > > > > We'd just need mlx4 to not expose DEV_RX_OFFLOAD_CRC_STRIP at all in > > mlx5_get_rx_queue_offloads() in order to fully comply. > > > > I leave it up to you, I don't mind if we include this patch only to > > revert it later when we finally get rid of DEV_RX_OFFLOAD_CRC_STRIP. > > A new flag to keep CRC will be introduced. > We will need toggling anyway.
Do we have such CRC flag already? If not I will include this patch and we revert/adjust it when the new flag will be introduced. > >