On Wednesday, March 03/28/18, 2018 at 14:00:58 +0530, Shahaf Shuler wrote: > Wednesday, March 28, 2018 10:40 AM, Rahul Lakkireddy: > > On Wednesday, March 03/28/18, 2018 at 10:19:17 +0530, Shahaf Shuler > > > > > > What exactly is the offload you try to expose? To strip the inner VLAN > > > while > > keeping the outer one? > > > > > > > Sorry about that, I should have provided more details on this earlier. > > Chelsio hardware supports below for double-vlans: > > 1) Dropping Outer VLAN in hw; inner vlan is stripped and available as packet > > metadata. > > So this is basically the DEV_RX_OFFLOAD_QINQ_STRIP with limitation from your > device you cannot return the outer vlan in the packet metadata >
Since this is specific to Chelsio devices, is it better handled by devargs approach instead? We will respin this particular patch separately. Hi Ferruh, Should we re-post the entire series minus this particular patch? > > 2) Preserving Outer VLAN so, Outer VLAN is stripped and available as packet > > metadata. Inner VLAN is available as part of packet itself. > > And this one is the regular DEV_RX_OFFLOAD_VLAN_STRIP > > > > > So, the configurability here is with respect to Outer VLAN and subsequently > > what is available as part of packet metadata (outer or inner vlan). Inner > > VLAN gets retained in both cases. However, based on how Outer VLAN is > > configured, Inner VLAN will be available either as packet metadata or as > > part > > of packet itself. > > > > We are not very sure if DEV_RX_OFFLOAD_QINQ_STRIP could be used here. > > If it holds the same meaning then we will use the same. > > Yeah , we are missing good documentation of what each offload means. > > > > Thanks, > > Rahul
