Hi Reshma:
Thanks for your review and I accepted most of your comments except:
1. doc and code will still be merged in one patch to follow the usual
way when we add a new API.
2. code re-org for "ifndef _cpluscplus", is not the scope of the patch,
it could be done separately.
For others I will fix in v2.
Thanks.
Qi
> -----Original Message-----
> From: Pattan, Reshma
> Sent: Thursday, March 29, 2018 11:23 PM
> To: Zhang, Qi Z <[email protected]>; [email protected]
> Cc: [email protected]; Doherty, Declan <[email protected]>; Chandran,
> Sugesh <[email protected]>; Glynn, Michael J
> <[email protected]>; Liu, Yu Y <[email protected]>; Ananyev,
> Konstantin <[email protected]>; Richardson, Bruce
> <[email protected]>; Zhang, Qi Z <[email protected]>
> Subject: RE: [dpdk-dev] [PATCH 4/4] ether: add packet modification aciton in
> flow API
>
> Hi,
>
> > Subject: [dpdk-dev] [PATCH 4/4] ether: add packet modification aciton in
> flow
>
> Typo in the commit message header "action"
>
> > +/** RTE_FLOW_ACTION_TYPE_FIELD_INCREMENT
> > + *
> > + * Increment 1 on specific field of the packet.
> > + *
> > + * Typical usage: increase TTL
> > + */
> > +struct rte_flow_action_field_increment {
> > + const struct rte_flow_item *item; /**< specify the data to modify. */
> > + uint8_t layer;
> > + /**< 0 means outermost matched pattern, 1 means next-to-
> > outermost...
> > +*/ };
> > +
> > +/** RTE_FLOW_ACTION_TYPE_FIELD_DECREMENT
> > + *
> > + * Decrement 1 on specific field of the packet.
> > + *
> > + * Typical usage: Decrease TTL
> > + */
> > +struct rte_flow_action_field_decrement {
> > + const struct rte_flow_item *item; /**< Specify the data to modify. */
> > + uint8_t layer;
> > + /**< 0 means outermost matched pattern, 1 means next-to-
> > outermost...
> > +*/ };
> > +
>
> Can you have only one struct to represent both increment/decrements
> operations instead of two structs? As I see both use same data types .
>
> Thanks,
> Reshma
