Hi Jerin, Question in-line:
> -----Original Message----- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Monday, April 2, 2018 6:19 PM > To: Carrillo, Erik G <erik.g.carri...@intel.com> > Cc: pbhagavat...@caviumnetworks.com; dev@dpdk.org; > hemant.agra...@nxp.com > Subject: Re: [PATCH v9 0/9] eventtimer: introduce event timer adapter > > -----Original Message----- > > Date: Mon, 2 Apr 2018 14:39:45 -0500 > > From: Erik Gabriel Carrillo <erik.g.carri...@intel.com> > > To: pbhagavat...@caviumnetworks.com > > CC: dev@dpdk.org, jerin.ja...@caviumnetworks.com, > > hemant.agra...@nxp.com > > Subject: [PATCH v9 0/9] eventtimer: introduce event timer adapter > > X-Mailer: git-send-email 1.7.10 > > > > This patch series contains the next iteration of the Event Timer > > Adapter library, which abstracts timer mechanisms that are tightly > > coupled with event devices, and extends the event based programming > > model so that timer expirations are represented as an event. > > > > v9 > > - Addressed comments on previous series from Pavan: > > - Don't assume services exist in HW cases > > - Adjust retry logic in a couple of tests > > - Addressed comments on previous series from Jerin: > > - Fix build warning > > - Addressed comments on previous series from Hemant: > > - Adjust copyright text > > 1) Please fix following check-patch warnings: > > ### eventtimer: introduce event timer adapter > > ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar" > #273: FILE: lib/librte_eventdev/rte_event_timer_adapter.h:238: > +struct rte_event_timer_adapter * __rte_experimental > > ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar" > #303: FILE: lib/librte_eventdev/rte_event_timer_adapter.h:268: > +struct rte_event_timer_adapter * __rte_experimenta > I was aware that checkpatch was complaining here, but the style I used is consistent with almost all the existing DPDK code that uses the __rte_experimental tag. Should I fix the warning if the style will differ from existing code? Thanks, Gabriel
