> -----Original Message----- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pavan Nikhilesh > Sent: Friday, April 6, 2018 7:31 PM > To: jerin.ja...@caviumnetworks.com; Yigit, Ferruh <ferruh.yi...@intel.com>; > pascal.ma...@6wind.com; Varghese, Vipin <vipin.vargh...@intel.com>; > tho...@monjalon.net > Cc: dev@dpdk.org; Pavan Nikhilesh <pbhagavat...@caviumnetworks.com> > Subject: [dpdk-dev] [PATCH] net/tap: fix memcpy with incorrect size > > Fix incorrect sizeof operation being used for getting mac addr size. > > Found while compiling with arm64 clang. > drivers/net/tap/rte_eth_tap.c:1410:40: error: argument to 'sizeof' in > 'memcpy' call is the same pointer type 'struct ether_addr *' as the > destination; expected 'struct ether_addr' or an explicit length > [-Werror,-Wsizeof-pointer-memaccess] > rte_memcpy(&pmd->eth_addr, mac_addr, sizeof(mac_addr)); > ~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~ > > Fixes: bcab6c1d27fa ("net/tap: allow user MAC to be passed as args") > > Signed-off-by: Pavan Nikhilesh <pbhagavat...@caviumnetworks.com> > ---
Good catch! Acked-by: Zhiyong Yang <zhiyong.y...@intel.com>
