As summarized in a prior RFC [1], the flow API (rte_flow) was chosen as a means to manage switch offloads supported by many devices (usually going by names such as E-Switch or vSwitch) through user-specified flow rules.
Combined with the need to support encap/decap actions, this requires a change in the way flow actions are processed (in order and possibly repeated) which modifies the behavior of some of the existing actions, thus warranting a major ABI breakage. Given this ABI breakage is also required by other work submitted for the current release [2][3], this series addresses various longstanding issues with the flow API and makes minor improvements in preparation for upcoming features. Changes summary: - Additional error types. - Clearer documentation. - Improved C++ compatibility. - Exhaustive RSS action. - Consistent behavior of VLAN pattern item. - New "transfer" attribute bringing consistency to VF/PF pattern items. - Confusing "PORT" pattern item renamed "PHY_PORT", with new action counterpart. - New "PORT_ID" pattern item and action to be used with port representors. This series piggybacks on the major ABI update introduced by a prior commit [4] for DPDK 18.05 and depends on several fixes [5] which must be applied first. [1] "[RFC] Switch device offload with DPDK" http://dpdk.org/ml/archives/dev/2018-March/092513.html [2] commit 676b605182a5 ("doc: announce ethdev API change for RSS configuration") [3] "[PATCH v1 00/21] MLX5 tunnel Rx offloading" http://dpdk.org/ml/archives/dev/2018-March/092264.html [4] commit 653e038efc9b ("ethdev: remove versioning of filter control function") [5] "[PATCH v3 00/11] Bunch of flow API-related fixes" http://dpdk.org/ml/archives/dev/2018-April/095762.html v2 changes: - Squashed "ethdev: update ABI for flow API functions" in subsequent patches. - Emphasized ABI impact in relevant commit logs. - Modified documentation in "ethdev: alter behavior of flow API actions" to describe how terminating flow rules without any action of the fate kind result in undefined behavior instead of dropping traffic. - Fixed other minor documentation formatting issues. - Modified "ethdev: refine TPID handling in flow API" as follows: - Using standard macro definitions for VLAN, QinQ and E-Tag EtherTypes. - Fixed endian conversion in sfc. - Replaced a condition in VLAN pattern item processing with an assertion check for i40e. Adrien Mazarguil (15): ethdev: add error types to flow API ethdev: clarify flow API pattern items and actions doc: remove flow API migration section ethdev: remove DUP action from flow API ethdev: alter behavior of flow API actions ethdev: remove C99 flexible arrays from flow API ethdev: flatten RSS configuration in flow API ethdev: add hash function to RSS flow API action ethdev: add encap level to RSS flow API action ethdev: refine TPID handling in flow API ethdev: add transfer attribute to flow API ethdev: update behavior of VF/PF in flow API ethdev: rename physical port item in flow API ethdev: add physical port action to flow API ethdev: add port ID item and action to flow API app/test-pmd/cmdline_flow.c | 405 ++++++++++----- app/test-pmd/config.c | 78 +-- doc/guides/nics/tap.rst | 2 +- doc/guides/prog_guide/rte_flow.rst | 602 ++++++++--------------- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 54 +- drivers/net/bnxt/bnxt_filter.c | 53 +- drivers/net/e1000/e1000_ethdev.h | 13 +- drivers/net/e1000/igb_ethdev.c | 4 +- drivers/net/e1000/igb_flow.c | 83 +++- drivers/net/e1000/igb_rxtx.c | 55 ++- drivers/net/enic/enic_flow.c | 53 +- drivers/net/i40e/i40e_ethdev.c | 57 ++- drivers/net/i40e/i40e_ethdev.h | 15 +- drivers/net/i40e/i40e_flow.c | 139 ++++-- drivers/net/ixgbe/ixgbe_ethdev.c | 7 +- drivers/net/ixgbe/ixgbe_ethdev.h | 13 +- drivers/net/ixgbe/ixgbe_flow.c | 91 +++- drivers/net/ixgbe/ixgbe_rxtx.c | 55 ++- drivers/net/mlx4/mlx4.c | 2 +- drivers/net/mlx4/mlx4_flow.c | 117 +++-- drivers/net/mlx4/mlx4_flow.h | 2 +- drivers/net/mlx4/mlx4_rxq.c | 2 +- drivers/net/mlx4/mlx4_rxtx.h | 2 +- drivers/net/mlx5/mlx5_flow.c | 319 ++++++------ drivers/net/mlx5/mlx5_rxq.c | 22 +- drivers/net/mlx5/mlx5_rxtx.h | 26 +- drivers/net/mvpp2/mrvl_flow.c | 33 +- drivers/net/sfc/sfc_flow.c | 83 +++- drivers/net/tap/tap_flow.c | 51 +- examples/ipsec-secgw/ipsec.c | 21 +- lib/librte_ether/rte_ethdev_version.map | 22 +- lib/librte_ether/rte_flow.c | 68 +-- lib/librte_ether/rte_flow.h | 329 ++++++++----- lib/librte_net/rte_ether.h | 1 + 34 files changed, 1755 insertions(+), 1124 deletions(-) -- 2.11.0