Hi Jiayu, > -----Original Message----- > From: Hu, Jiayu [mailto:[email protected]] > Sent: Tuesday, April 24, 2018 3:56 PM > To: Ananyev, Konstantin <[email protected]>; Ophir Munk > <[email protected]>; [email protected] > Cc: Thomas Monjalon <[email protected]>; Olga Shern > <[email protected]>; Pascal Mazon <[email protected]>; > [email protected] > Subject: RE: [PATCH v1] gso: fix marking TCP checksum flag in TCP segments > > Hi Konstantin and Ophir, > ... > > Another possibility - might be make chages in librte_gso to allow user > > to specify what flags to set for the output packets (probably via > > rte_gso_ctx.flag) > > It would be a solution. We can add flags to rte_gso_ctx.flag and the GSO > library can do some extra work (like checksum) according to the flags. >
I think that calculating TCP checksums by GSO library should be optional (if at all). In my case I prefer TAP PMD to do the work which is TAP-specific. My original intention in this patch was only to mark PKT_TX_TCP_CKSUM flag. > Thanks, > Jiayu > > > > Konstantin > > ...
