HI Ferruh,
> Hi Hemant, > > Overall this looks good to me, thanks. > > Only I would like to ask if you prefer to replace nodis and not_supported > checks. > > Because with current order, if an offlaod requested that both has not > supported > offload and not enable all nodis offloads, this will print both logs and > return > error. Since it will return error, do you really need "non configurable" log? > > If you replace checks, if any not supported offload requested it will only > print log > for it and return error without checking/caring nodis offloads. > > It is up to you, please let me know if you want to go with existing set. [Hemant] Thanks for the review. In v4, I have reversed the order of check Regards, Hemant > > Thanks, > ferruh
