On Fri, Apr 27, 2018 at 06:07:04PM +0100, Anatoly Burakov wrote:
> We were closing descriptor before checking if mapping has
> failed, but if it did, we did a second close afterwards. Fix
> it by moving closing descriptor to after we've done all error
> checks.
>
> Coverity issue: 272560
>
> Fixes: 2a04139f66b4 ("eal: add single file segments option")
> Cc: [email protected]
>
> Signed-off-by: Anatoly Burakov <[email protected]>
> ---
>
> Notes:
> v4:
> - Moved fd close to until after all error checks are done
>
Acked-by: Bruce Richardson <[email protected]>
- Re: [dpdk-dev] [PATCH v3 4/9] mem: fix potential... Burakov, Anatoly
- Re: [dpdk-dev] [PATCH v3 4/9] mem: fix potential... Burakov, Anatoly
- Re: [dpdk-dev] [PATCH v3 4/9] mem: fix poten... Bruce Richardson
- [dpdk-dev] [PATCH v3 8/9] mem: fix statement having no ef... Anatoly Burakov
- Re: [dpdk-dev] [PATCH v3 8/9] mem: fix statement hav... Bruce Richardson
- [dpdk-dev] [PATCH v3 9/9] mem: fix possible use-after-fre... Anatoly Burakov
- Re: [dpdk-dev] [PATCH v3 9/9] mem: fix possible use-... Bruce Richardson
- [dpdk-dev] [PATCH v4 0/9] Coverity fixes for EAL memory Anatoly Burakov
- [dpdk-dev] [PATCH v4 1/9] mem: use strlcpy instead o... Anatoly Burakov
- [dpdk-dev] [PATCH v4 3/9] mem: fix potential double ... Anatoly Burakov
- Re: [dpdk-dev] [PATCH v4 3/9] mem: fix potential... Bruce Richardson
- [dpdk-dev] [PATCH v4 5/9] mem: fix potential resourc... Anatoly Burakov
- [dpdk-dev] [PATCH v4 2/9] mem: fix resource leak Anatoly Burakov
- [dpdk-dev] [PATCH v4 4/9] mem: fix potential resourc... Anatoly Burakov
- [dpdk-dev] [PATCH v4 6/9] mem: fix comparing pointer... Anatoly Burakov
- [dpdk-dev] [PATCH v4 8/9] mem: fix statement having ... Anatoly Burakov
- [dpdk-dev] [PATCH v4 7/9] mem: fix potential bad unm... Anatoly Burakov
- [dpdk-dev] [PATCH v4 9/9] mem: fix possible use-afte... Anatoly Burakov
- Re: [dpdk-dev] [PATCH v4 0/9] Coverity fixes for EAL... Thomas Monjalon

